Skip to main content

Hardening shell_exec, system, exec and similar shell functions?

Comments

8 comments

  • User Avatar
    sehh
    That's easy:
    0
  • User Avatar
    ITGabs
    Thanks sehh, are you the developer of this patch or mod? very clever and very strange that this is not included in the php core.
    0
  • User Avatar
    sehh
    I only made the cPanel/WHM module, I am not the developer of the php patch. I always wondered the same thing, this is a must-have security enhancement! I've seen it work with devastating results, the uploaded backdoor script couldn't execute any commands it wanted to scan the system. Unfortunately, the patch hasn't been accepted to mainline php, that is why I made the module, now it automatically installs on all my servers.
    0
  • User Avatar
    cPanelKenneth
    Please be advised that doing a recursive chown, as root, in the user's home directory is an unsafe operation. It can allow a malicious user to take ownership of any file on the same file system as his home directory. Simple example, assuming /etc is on the same partition: As User: $ ln /etc/shadow ~/www/my_meeting_notes.txt As root: #chown -R user:user /home/user/www User now owns /etc/shadow.
    0
  • User Avatar
    sehh
    That is correct. That is why it is better to use "find" first. By default, it does NOT follow symbolic links (-P parameter), thus it will never follow the link to /etc/shadow as your example above. #find -P -print0 /home/user/www | xargs -0 chown user:user "find" parameters: -P = do not follow symbolic links -print0 = print the full file name on the standard output, followed by a null character. "xargs" parameters: -0 = Input items are terminated by a null character instead of by whitespace, and the quotes and backslash are not special The strange -print0 and -0 combination of parameters in "find" and "xargs" are there to help with files and paths that have special characters in them and/or spaces! Or just sudo as the user and run the command with the users permissions/ownership. How is that for a comprehensive answer? :D
    0
  • User Avatar
    cPanelKenneth
    [quote="sehh, post: 1483401">That is correct. That is why it is better to use "find" first. By default, it does NOT follow symbolic links (-P parameter), thus it will never follow the link to /etc/shadow as your example above. #find -P -print0 /home/user/www | xargs -0 chown user:user "find" parameters: -P = do not follow symbolic links -print0 = print the full file name on the standard output, followed by a null character. "xargs" parameters: -0 = Input items are terminated by a null character instead of by whitespace, and the quotes and backslash are not sp cial The strange -print0 and -0 combination of parameters in "find" and "xargs" are there to help with files and paths that have special characters in them and/or spaces! Or just sudo as the user and run the command with the users permissions/ownership. How is that for a comprehensive answer? :D
    I didn't create a symbolic link. I created a hard link. They are very different things.
    0
  • User Avatar
    sehh
    Oh, indeed, I didn't notice, sorry for that :(
    0
  • User Avatar
    cPanelKenneth
    [quote="sehh, post: 1483592">Oh, indeed, I didn't notice, sorry for that :(
    no problem. symlinks get so much attention that everyone forgets about hard links. :) Filtering out things not owned by the user is a general safety step, but doesn't necessarily accomplish your goal.
    0

Please sign in to leave a comment.