Skip to main content

cPanel Themes, Icons, and you!

Comments

144 comments

  • stormy
    Is there any documentation on how to actually override the icons? I can see a list of icons here, and their filenames:
    0
  • cPRex Jurassic Moderator
    No, overriding the icons isn't something we support at this point.
    0
  • stormy
    No, overriding the icons isn't something we support at this point.

    Thanks. There really seems to be some kind of power struggle here between cPanel and its user base. I understand that brand considerations make you want to keep some kind of unified look, but if people love the old icons so much, and they were part of the brand - why not offer them officially? Anyway, I don"t want to beat a dead horse here. I appreciate all you"re doing in the forum!
    0
  • AzeDK
    No, overriding the icons isn't something we support at this point.

    Any chance we can get a better icon for "File Manager" ? I don't see the logic in having a person face as the biggest part of the icon. It would be better if you took the "File tree" from the "Mailing Lists" icon and kept the folder in the corner. The current "File Manager" icon always confuses me with the "Email Accounts" icon, as both are the first icon in the category, and both have the similar person in it. I have added my take on how File Manager icon could look.
    0
  • cPRex Jurassic Moderator
    @AzeDK - I've passed that along to the UI team!
    0
  • stormy
    Apparently cPanel is taking measures to overwrite any custom icons. Can you confirm that?
    0
  • cPRex Jurassic Moderator
    I'm not aware of such a thing - what are you seeing?
    0
  • stormy
    I'm not aware of such a thing - what are you seeing?

    Well, if you're not aware, you're not, but it's a thing. I'll leave it at that.
    0
  • PeteS
    Well, if you're not aware, you're not, but it's a thing. I'll leave it at that.

    Instead of leaving it "at that," how about telling us what you tried and what's not working about it? There are plenty of people that would be interested in customizing icons.
    0
  • cPRex Jurassic Moderator
    @stormy - what @PeteS said. You've hung around here long enough to know that if you provide me with reproduction steps, I'll happily test something.
    0
  • stormy
    Ok. With the latest cPanel update, /scripts/upcp actively searches for some code that was shared in the forum (in a thread that was locked afterwards), and removes it from /scripts/postupcp. I got a laugh out of it.
    0
  • cPRex Jurassic Moderator
    Can you post the code snippet or link to that thread so I can confirm this?
    0
  • stormy
    Sorry don't have a lot of time for this now but this is the infamous locked thread:
    0
  • martin MHC
    Can you post the code snippet or link to that thread so I can confirm this?

    I also use the same code block on the locked thread, and to avoid this overwriting (and various other aspects) I have prevented my WHM updating beyond 102 for now, until there's a better GUI (and various other aspects) in place. With respect to Stormy's message, the script that imports the old icons should be run from the /usr/local/cpanel/scripts/postupcp_icons address, which is a CPanel propriatory script and so this was why the old thread on the forum was locked (according to the lock message) . The destination location of all icons actively used by CPanel (whereever they came from) is apparently: dest=/usr/local/cpanel/whostmgr/docroot/themes/x/icons/ . If this address has changed then that's why the new icons are not being replaced.
    0
  • cPRex Jurassic Moderator
    A few thoughts. /usr/local/cpanel/scripts/postupcp_icons is not something created by cPanel. This was the recommended file path by the user - he even says " File ( can't upload core file so please copy and paste and save as postupcp_icons )" So we wouldn't edit/remove that file. Is that what you're seeing happening?
    0
  • stormy
    Ok, now that the cat is out of the bag, I'll come out and say it. /scripts/upcp is actively searching for "/usr/local/cpanel/scripts/postupcp_icons" inside /scripts/postupcp and removing that line if found. I got a chuckle out of it. Very nice "mouse and cat" game! :D Now, can you please tell the developers to leave that alone?
    0
  • cPRex Jurassic Moderator
    @stormy - our update doesn't remove any data from the /scripts/postupcp file. I just tested this to confirm. Like I mentioned earlier, cPanel doesn't own or create /usr/local/cpanel/scripts/postupcp_icons - that's something that @martin MHC recommended for the filename, so we wouldn't have any knowledge of the file.
    0
  • stormy
    upcp removes the call to /scripts/postupcp_icons from /scripts/postupcp. Tested on 3 servers. But that's ok, I'll live :)
    0
  • cPRex Jurassic Moderator
    Can you post *exactly* what your postupcp file looks like?
    0
  • stormy
    Not really, sorry! I appreciate your help here, by the way. I can post the line that got removed: /scripts/postupcp_icons # restore old icons
    That's the actual line that gets deleted by upcp. If I remove the comment, it gets deleted too. There are many ways around this so it's really not worth it to bother. I can run my fixes from other scripts, from the cron, manually whenever I feel like, etc. No big deal!
    0
  • PeteS
    /scripts/upcp is actively searching for "/usr/local/cpanel/scripts/postupcp_icons" inside /scripts/postupcp and removing that line if found.

    How? I just checked /scripts/upcp on a server and don't see that search: # cat /scripts/upcp | grep postupcp if ( -x '/usr/local/cpanel/scripts/postupcp' ) { $logger->info("Running /usr/local/cpanel/scripts/postupcp"); system '/usr/local/cpanel/scripts/postupcp'; ...and there is nothing in postupcp that would mess with anything, so I don't see how that is happening for you.
    0
  • stormy
    It started to happen with cPanel 110.0.5. I just verified it again. EDIT: I found it and it's not a cPanel caused issue. It's a side effect of a Cloudlinux script that is called by upcp: /usr/local/cpanel/bin/cloudlinux_cleanoldhooks It's removing lines with postupcp in them: deleteAllInclude "$postupcp" "postupcp" "/#cpanel-lve/d" deleteAllInclude "$postupcp" "postupcp" "/#CloudLinux/d"
    Mystery solved! And sorry for the confusion caused. I'm happy that nobody at cPanel spent time trying to interfere with this!!! And sorry for the confusion and wasting your time @PeteS and @cPRex
    0
  • PeteS
    It started to happen with cPanel 110.0.5. I just verified it again. I'm not motivated enough to go through all the scripts that are called by upcp to see where the developers hid the code. Really, I applaud the effort - it's funny! :D

    I'm on 110.0.5. Just now: I created /scripts/postupcp_icons and placed the call in /scripts/postupcp After running /scripts/upcp the line is still in /scripts/postupcp, and /scripts/postupcp_icons still exists and executes. I'll check again in a day to see if the line still exists. I'm running a standard profile cPanel server, no CL or any abnormal mods. If upcp removes that line for you then something is odd indeed.
    0
  • stormy
    Thanks. It's Cloudlinux that's adding a call to /usr/local/cpanel/bin/cloudlinux_cleanoldhook inside the upcp process. Nothing cPanel related. Thanks everyone for the investigation!
    0

Please sign in to leave a comment.